Add support for std::string in folly::Hash

Reviewed By: @​liviu

Differential Revision: D2436705

diff --git a/folly/Hash.h b/folly/Hash.h
index f40f4ec27d620512239a7d85fa6f7cac83600863..07eb5571eb5a891f9d1907b399dcc64343cd2c06 100644 (file)
--- a/folly/Hash.h
+++ b/folly/Hash.h
@@ -375,6 +375,12 @@ template<> struct hasher<uint64_t> {
   }
 };
 
+template<> struct hasher<std::string> {
+  size_t operator()(const std::string& key) const {
+    return hash::SpookyHashV2::Hash64(key.data(), key.size(), 0);
+  }
+};
+
 template <class T>
 struct hasher<T, typename std::enable_if<std::is_enum<T>::value, void>::type> {
   size_t operator()(T key) const {

diff --git a/folly/test/HashTest.cpp b/folly/test/HashTest.cpp
index bbae4f6f29fcb07e9820141e2955ded2484b1f94..de12b1e02ae2b58ef55a12145803882efb58101d 100644 (file)
--- a/folly/test/HashTest.cpp
+++ b/folly/test/HashTest.cpp
@@ -303,7 +303,7 @@ TEST(Hash, std_tuple_different_hash) {
             std::hash<tuple3>()(t3));
 }
 
-TEST(Range, Hash) {
+TEST(Hash, Strings) {
   using namespace folly;
 
   StringPiece a1 = "10050517", b1 = "51107032",
@@ -329,4 +329,10 @@ TEST(Range, Hash) {
   EXPECT_NE(h2(w1), h2(w2));
   EXPECT_NE(h2(w1), h2(w3));
   EXPECT_NE(h2(w2), h2(w4));
+
+  // Check compatibility with std::string.
+  EXPECT_EQ(h2(a1), h2(a1.str()));
+  EXPECT_EQ(h2(a2), h2(a2.str()));
+  EXPECT_EQ(h2(a3), h2(a3.str()));
+  EXPECT_EQ(h2(a4), h2(a4.str()));
 }