Pass the error string directly to llvm_unreachable instead of the residual
authorJohn McCall <rjmccall@apple.com>
Fri, 18 Dec 2009 00:27:18 +0000 (00:27 +0000)
committerJohn McCall <rjmccall@apple.com>
Fri, 18 Dec 2009 00:27:18 +0000 (00:27 +0000)
(0 && "error").  Rough consensus seems to be that g++ *should* be diagnosing
this because the pointer makes it not an ICE in c++03.  Everyone agrees that
the current standard is silly and null-pointer-ness should not be based on
ICE-ness.  Excellent fight scene in Act II, denouement weak, two stars.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@91644 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/MSP430/AsmPrinter/MSP430MCInstLower.cpp

index f505b239b6313728052c30f6f9d6ecc103ff715e..595b7e789c7d219f5702731639601e8289525e29 100644 (file)
@@ -34,7 +34,7 @@ GetGlobalAddressSymbol(const MachineOperand &MO) const {
   Mang.getNameWithPrefix(Name, GV, false);
 
   switch (MO.getTargetFlags()) {
-  default: llvm_unreachable(0 && "Unknown target flag on GV operand");
+  default: llvm_unreachable("Unknown target flag on GV operand");
   case 0: break;
   }