mmc: sdhci-pxav3: Remove checks for optional core clock in error/remove path
authorJisheng Zhang <jszhang@marvell.com>
Mon, 5 Jan 2015 07:59:19 +0000 (15:59 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 21 Jan 2015 13:20:01 +0000 (14:20 +0100)
Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to
clk_{unprepare, disable}()") allows NULL or error pointer to be passed
unconditionally.

This patch is to simplify probe error and remove code paths.

However, we reserve the core clock checks in runtime suspend/resume code
because we want a little smaller latency.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-pxav3.c

index 4de39fb6dc2df0d74d78e035b3c7c80615abf1ca..63967b85dc4221fb3d2bef7d2563a6d553429e0e 100644 (file)
@@ -398,8 +398,7 @@ err_of_parse:
 err_cd_req:
 err_mbus_win:
        clk_disable_unprepare(pxa->clk_io);
-       if (!IS_ERR(pxa->clk_core))
-               clk_disable_unprepare(pxa->clk_core);
+       clk_disable_unprepare(pxa->clk_core);
 err_clk_get:
        sdhci_pltfm_free(pdev);
        return ret;
@@ -418,8 +417,7 @@ static int sdhci_pxav3_remove(struct platform_device *pdev)
        sdhci_remove_host(host, 1);
 
        clk_disable_unprepare(pxa->clk_io);
-       if (!IS_ERR(pxa->clk_core))
-               clk_disable_unprepare(pxa->clk_core);
+       clk_disable_unprepare(pxa->clk_core);
 
        sdhci_pltfm_free(pdev);