PCI: fix wrong assumption in pci_get_interrupt_pin
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Tue, 17 Feb 2009 05:15:45 +0000 (14:15 +0900)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Fri, 20 Mar 2009 17:48:04 +0000 (10:48 -0700)
Current pci_get_interrupt_pin() seems to have an assumption that
pci_bus->self is NULL on the root pci bus. But it might not be true on
some platforms. Because of this wrong assumption, current
pci_get_interrupt_pin() might cause endless loop. We must check
pci_bus->parent instead.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/pci.c

index 0b3e20f1b6f7b8b30e70eb3b7ae415df87280b6e..0cfed9e28ea14490e0d973516e5053e79f92f59e 100644 (file)
@@ -1484,7 +1484,7 @@ pci_get_interrupt_pin(struct pci_dev *dev, struct pci_dev **bridge)
        if (!pin)
                return -1;
 
-       while (dev->bus->self) {
+       while (dev->bus->parent) {
                pin = pci_swizzle_interrupt_pin(dev, pin);
                dev = dev->bus->self;
        }