DM RAID: Use md_error() in place of simply setting Faulty bit

When encountering an error while reading the superblock, call md_error.

We are currently setting the 'Faulty' bit on one of the array devices when an
error is encountered while reading the superblock of a dm-raid array.  We should
be calling md_error(), as it handles the error more completely.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index f1797c4f09c40dbd61348029f4bc12c105295c8c..017c34d78d61f7ca42cfc0221449b4b55ab40052 100644 (file)
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -603,7 +603,7 @@ static int read_disk_sb(struct md_rdev *rdev, int size)
        if (!sync_page_io(rdev, 0, size, rdev->sb_page, READ, 1)) {
                DMERR("Failed to read superblock of device at position %d",
                      rdev->raid_disk);
-               set_bit(Faulty, &rdev->flags);
+               md_error(rdev->mddev, rdev);
                return -EINVAL;
        }