[SCSI] libfc: discovery restart sequence error fix
authorJoe Eykholt <jeykholt@cisco.com>
Tue, 25 Aug 2009 21:02:17 +0000 (14:02 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Thu, 10 Sep 2009 17:07:49 +0000 (12:07 -0500)
When an RSCN is received during fabric discovery, it restarts.
After the restart, disc->seq_count was incremented, so when
the first frame was received, it was considered "out of sequence".
That left the state disc->active, preventing further discoveries.

Change to advance the sequence count before parsing, so that it
won't be changed after a potential restart.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/libfc/fc_disc.c

index ddf494424ff4efd12e759d9cc090b8c6b956d51c..fd3a6b287e9822ae8a50994cdd3a85d5a2c28910 100644 (file)
@@ -629,11 +629,10 @@ static void fc_disc_gpn_ft_resp(struct fc_seq *sp, struct fc_frame *fp,
                            seq_cnt, disc->seq_count, fr_sof(fp), fr_eof(fp));
        }
        if (buf) {
+               disc->seq_count++;
                error = fc_disc_gpn_ft_parse(disc, buf, len);
                if (error)
                        fc_disc_error(disc, fp);
-               else
-                       disc->seq_count++;
        }
        fc_frame_free(fp);