mwifiex: memory corruption in mwifiex_tdls_add_vht_capab()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 14 Feb 2014 09:03:13 +0000 (12:03 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 24 Feb 2014 20:21:53 +0000 (15:21 -0500)
There is a typo here because the names are confusingly similar.  The
intent was sizeof(struct ieee80211_vht_cap) (size 12) but sizeof(struct
ieee80211_ht_cap) (size 32) was used.

Anway, it's cleaner to just specify the variable instead of the type.

Fixes: 5f6d5983394f ('mwifiex: add VHT support for TDLS')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/mwifiex/tdls.c

index 5efd456af5715380c363106b1d2eee47ea77ffd0..1ba2a16ee47143845f97837a66851d44589c2292 100644 (file)
@@ -180,7 +180,7 @@ static int mwifiex_tdls_add_vht_capab(struct mwifiex_private *priv,
        memset(&vht_cap, 0, sizeof(struct ieee80211_vht_cap));
 
        mwifiex_fill_vht_cap_tlv(priv, &vht_cap, priv->curr_bss_params.band);
-       memcpy(pos, &vht_cap, sizeof(struct ieee80211_ht_cap));
+       memcpy(pos, &vht_cap, sizeof(vht_cap));
 
        return 0;
 }