usb/host/fotg210: convert macro to inline function
authorPeter Senna Tschudin <peter.senna@gmail.com>
Mon, 12 Oct 2015 21:22:38 +0000 (23:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Oct 2015 06:46:27 +0000 (23:46 -0700)
This patch convert the macro speed_char in an inline function. The goal
of this patch is to make the code easier to read.

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/fotg210-hcd.c

index f3c1a718fe0b66e1b83b10d26887b2f3264429a3..158423230a884c89eb651d94ccfda573e4b277ff 100644 (file)
@@ -330,17 +330,22 @@ struct debug_buffer {
        size_t alloc_size;
 };
 
-#define speed_char(info1)({ char tmp; \
-               switch (info1 & (3 << 12)) { \
-               case QH_FULL_SPEED:     \
-                       tmp = 'f'; break; \
-               case QH_LOW_SPEED:      \
-                       tmp = 'l'; break; \
-               case QH_HIGH_SPEED:     \
-                       tmp = 'h'; break; \
-               default:                \
-                       tmp = '?'; break; \
-               } tmp; })
+static inline char speed_char(u32 scratch)
+{
+       switch (scratch & (3 << 12)) {
+       case QH_FULL_SPEED:
+               return 'f';
+
+       case QH_LOW_SPEED:
+               return 'l';
+
+       case QH_HIGH_SPEED:
+               return 'h';
+
+       default:
+               return '?';
+       }
+}
 
 static inline char token_mark(struct fotg210_hcd *fotg210, __hc32 token)
 {