Comparing the same tokens

Summary:
Avoid comparing-the-same-tokens error by parenthesizing one
side.

This diff only touches folly tests

Test Plan: run unit tests

Reviewed By: robbert@fb.com

Subscribers: sdwilsh, njormrod, folly-diffs@

FB internal diff: D1650386

Tasks: 5486739

Signature: t1:1650386:1414713837:cbb578d23f759aa049f4246113d9da6d40504da4

diff --git a/folly/test/MacAddressTest.cpp b/folly/test/MacAddressTest.cpp
index d40f795ac53790c8afd5fb478e0aaf351c59d06a..3f00011b1c5a0e9bb9713725ebe3cad8999c06f6 100644 (file)
--- a/folly/test/MacAddressTest.cpp
+++ b/folly/test/MacAddressTest.cpp
@@ -149,7 +149,7 @@ void testCmp(const char* str1, const char* str2) {
   EXPECT_TRUE(m2 > m1);
   EXPECT_TRUE(m2 >= m1);
   EXPECT_TRUE(m1 != m2);
-  EXPECT_TRUE(m1 == m1);
+  EXPECT_TRUE(m1 == (m1));
   EXPECT_FALSE(m1 == m2);
 
   // Also test the copy constructor and assignment operator

diff --git a/folly/test/OptionalTest.cpp b/folly/test/OptionalTest.cpp
index 58a20685dfdb9cac218ec3d1b7570d1eae44e828..4699f615799e4f6d0950a079db66e3ead86c9aed 100644 (file)
--- a/folly/test/OptionalTest.cpp
+++ b/folly/test/OptionalTest.cpp
@@ -282,16 +282,16 @@ TEST(Optional, Comparisons) {
   Optional<int> o1(1);
   Optional<int> o2(2);
 
-  EXPECT_TRUE(o_ <= o_);
-  EXPECT_TRUE(o_ == o_);
-  EXPECT_TRUE(o_ >= o_);
+  EXPECT_TRUE(o_ <= (o_));
+  EXPECT_TRUE(o_ == (o_));
+  EXPECT_TRUE(o_ >= (o_));
 
   EXPECT_TRUE(o1 < o2);
   EXPECT_TRUE(o1 <= o2);
-  EXPECT_TRUE(o1 <= o1);
-  EXPECT_TRUE(o1 == o1);
+  EXPECT_TRUE(o1 <= (o1));
+  EXPECT_TRUE(o1 == (o1));
   EXPECT_TRUE(o1 != o2);
-  EXPECT_TRUE(o1 >= o1);
+  EXPECT_TRUE(o1 >= (o1));
   EXPECT_TRUE(o2 >= o1);
   EXPECT_TRUE(o2 > o1);
 
@@ -299,7 +299,7 @@ TEST(Optional, Comparisons) {
   EXPECT_FALSE(o2 <= o1);
   EXPECT_FALSE(o2 <= o1);
   EXPECT_FALSE(o2 == o1);
-  EXPECT_FALSE(o1 != o1);
+  EXPECT_FALSE(o1 != (o1));
   EXPECT_FALSE(o1 >= o2);
   EXPECT_FALSE(o1 >= o2);
   EXPECT_FALSE(o1 > o2);