BUG_ON() Conversion in fs/coda/
authorEric Sesterhenn <snakebyte@gmx.de>
Fri, 24 Mar 2006 17:42:13 +0000 (18:42 +0100)
committerAdrian Bunk <bunk@stusta.de>
Fri, 24 Mar 2006 17:42:13 +0000 (18:42 +0100)
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
fs/coda/cache.c
fs/coda/cnode.c

index c607d923350a4ee1bb46259ddd39d9761301bb72..5d0527133266c9a44cb800c7c2e41979dcaf964e 100644 (file)
@@ -51,7 +51,7 @@ void coda_cache_clear_all(struct super_block *sb)
         struct coda_sb_info *sbi;
 
         sbi = coda_sbp(sb);
-        if (!sbi) BUG();
+       BUG_ON(!sbi);
 
        atomic_inc(&permission_epoch);
 }
index 23aeef5aa8144a94dc69ea5abfc29ab286da77d7..4c9fecbfa91f1a82f09e531de40eb00612017bb0 100644 (file)
@@ -120,8 +120,7 @@ void coda_replace_fid(struct inode *inode, struct CodaFid *oldfid,
        
        cii = ITOC(inode);
 
-       if (!coda_fideq(&cii->c_fid, oldfid))
-               BUG();
+       BUG_ON(!coda_fideq(&cii->c_fid, oldfid));
 
        /* replace fid and rehash inode */
        /* XXX we probably need to hold some lock here! */