staging: emxx_udc: Remove cleanup1 label
authorRavi Teja Darbha <ravi2j@gmail.com>
Fri, 4 Sep 2015 19:38:29 +0000 (01:08 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Sep 2015 01:24:52 +0000 (18:24 -0700)
The cleanup1 label does nothing but return. Better way is to return
immediately instead of using goto. Hence, removed.

Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/emxx_udc/emxx_udc.c

index 8cef08d91551798771e005300df12172f5276069..ffb8a3dd1e1277350245d4224bd4a19e805dac17 100644 (file)
@@ -3284,14 +3284,14 @@ static int nbu2ss_drv_probe(struct platform_device *pdev)
        /* USB Function Controller Interrupt */
        if (status != 0) {
                dev_err(udc->dev, "request_irq(USB_UDC_IRQ_1) failed\n");
-               goto cleanup1;
+               return status;
        }
 
        /* Driver Initialization */
        status = nbu2ss_drv_contest_init(pdev, udc);
        if (status < 0) {
                /* Error */
-               goto cleanup1;
+               return status;
        }
 
        /* VBUS Interrupt */
@@ -3304,13 +3304,10 @@ static int nbu2ss_drv_probe(struct platform_device *pdev)
 
        if (status != 0) {
                dev_err(udc->dev, "request_irq(INT_VBUS) failed\n");
-               goto cleanup1;
+               return status;
        }
 
        return status;
-
-cleanup1:
-       return status;
 }
 
 /*-------------------------------------------------------------------------*/