brcmfmac: fix pkt_filter sizeof calculation.
authorHante Meuleman <meuleman@broadcom.com>
Tue, 6 Nov 2012 00:22:17 +0000 (16:22 -0800)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 14 Nov 2012 19:55:48 +0000 (14:55 -0500)
sizeof calculation in setting pkt_filter was incorrect. This
patch fixes that and removes related defines which have become
obsolete.

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c

index 866b66995bb072a4f6dffe68f4ee269a299a91c8..a70393a893d14a7e98b59ccb00caee0df6a1c133 100644 (file)
 
 #define MSGTRACE_VERSION       1
 
-#define BRCMF_PKT_FILTER_FIXED_LEN     offsetof(struct brcmf_pkt_filter_le, u)
-#define BRCMF_PKT_FILTER_PATTERN_FIXED_LEN     \
-       offsetof(struct brcmf_pkt_filter_pattern_le, mask_and_pattern)
-
 #ifdef DEBUG
 static const char brcmf_version[] =
        "Dongle Host Driver, version " BRCMF_VERSION_STR "\nCompiled on "
@@ -686,8 +682,8 @@ static void brcmf_c_pktfilter_offload_set(struct brcmf_if *ifp, char *arg)
        }
 
        pkt_filter->u.pattern.size_bytes = cpu_to_le32(mask_size);
-       buf_len = sizeof(*pkt_filter);
-       buf_len -= sizeof(pkt_filter->u.pattern.mask_and_pattern);
+       buf_len = offsetof(struct brcmf_pkt_filter_le,
+                          u.pattern.mask_and_pattern);
        buf_len += mask_size + pattern_size;
 
        err = brcmf_fil_iovar_data_set(ifp, "pkt_filter_add", pkt_filter,