[ARM] omap: move clock propagation into core omap clock code
authorRussell King <rmk@dyn-67.arm.linux.org.uk>
Thu, 13 Nov 2008 13:01:32 +0000 (13:01 +0000)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Sun, 8 Feb 2009 17:50:10 +0000 (17:50 +0000)
Move the clock propagation calls for set_parent and set_rate into
the core omap clock code, rather than having these calls scattered
throughout the OMAP1 and OMAP2 implementations.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/mach-omap1/clock.c
arch/arm/mach-omap2/clock.c
arch/arm/plat-omap/clock.c

index ff408105ffb24f4f534a7ce2037e10b1e7eaef81..ee1b9f20544a38c525849f328d00db3465f1d89d 100644 (file)
@@ -628,9 +628,6 @@ static int omap1_clk_set_rate(struct clk *clk, unsigned long rate)
                ret = 0;
        }
 
-       if (unlikely(ret == 0 && (clk->flags & RATE_PROPAGATES)))
-               propagate_rate(clk);
-
        return ret;
 }
 
index 76afb7b4482c5045fb78ea33e8176cd154b9cb96..7a1d56af9e470c439fd73407194a02c6f31c8f6d 100644 (file)
@@ -684,9 +684,6 @@ int omap2_clk_set_rate(struct clk *clk, unsigned long rate)
        if (clk->set_rate != NULL)
                ret = clk->set_rate(clk, rate);
 
-       if (unlikely(ret == 0 && (clk->flags & RATE_PROPAGATES)))
-               propagate_rate(clk);
-
        return ret;
 }
 
@@ -774,9 +771,6 @@ int omap2_clk_set_parent(struct clk *clk, struct clk *new_parent)
        pr_debug("clock: set parent of %s to %s (new rate %ld)\n",
                 clk->name, clk->parent->name, clk->rate);
 
-       if (unlikely(clk->flags & RATE_PROPAGATES))
-               propagate_rate(clk);
-
        return 0;
 }
 
index ae77e10719f250cde3ac06942a84afe26451595b..b7137c560db40a52160954860aac5d75eb985f1a 100644 (file)
@@ -182,6 +182,8 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
        spin_lock_irqsave(&clockfw_lock, flags);
        if (arch_clock->clk_set_rate)
                ret = arch_clock->clk_set_rate(clk, rate);
+       if (ret == 0 && (clk->flags & RATE_PROPAGATES))
+               propagate_rate(clk);
        spin_unlock_irqrestore(&clockfw_lock, flags);
 
        return ret;
@@ -198,7 +200,9 @@ int clk_set_parent(struct clk *clk, struct clk *parent)
 
        spin_lock_irqsave(&clockfw_lock, flags);
        if (arch_clock->clk_set_parent)
-               ret =  arch_clock->clk_set_parent(clk, parent);
+               ret = arch_clock->clk_set_parent(clk, parent);
+       if (ret == 0 && (clk->flags & RATE_PROPAGATES))
+               propagate_rate(clk);
        spin_unlock_irqrestore(&clockfw_lock, flags);
 
        return ret;