projects
/
firefly-linux-kernel-4.4.55.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cf2a320
)
[media] xc2028: add missing break to switch
author
Antti Palosaari
<crope@iki.fi>
Sat, 5 Apr 2014 20:23:44 +0000
(17:23 -0300)
committer
Mauro Carvalho Chehab
<m.chehab@samsung.com>
Sun, 6 Apr 2014 14:08:48 +0000
(11:08 -0300)
Coverity CID
1196501
: Missing break in switch (MISSING_BREAK)
I introduced that bug recently by commit
96a5b3a869e3dc7d55bf04a48a8dca8a4025787e
.
As a result, it will flood unintentionally error message to log.
Reported-by: <scan-admin@coverity.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/tuners/tuner-xc2028.c
patch
|
blob
|
history
diff --git
a/drivers/media/tuners/tuner-xc2028.c
b/drivers/media/tuners/tuner-xc2028.c
index 76a816511f2f34f9bd9d5886d549c59e8b6b5d96..6ef93ee1fdcb266780e32cd11d5736af3f24c24d 100644
(file)
--- a/
drivers/media/tuners/tuner-xc2028.c
+++ b/
drivers/media/tuners/tuner-xc2028.c
@@
-1107,6
+1107,7
@@
static int generic_set_freq(struct dvb_frontend *fe, u32 freq /* in HZ */,
offset += 200000;
}
#endif
+ break;
default:
tuner_err("Unsupported tuner type %d.\n", new_type);
break;