Mark future-core get-state members as const noexcept

Summary: [Folly] Mark future-core get-state members as `const noexcept`.

Reviewed By: andrewjcg

Differential Revision: D5014358

fbshipit-source-id: e39b0b63c59267a4ecfab5aac02e6d96ce2e7e00

diff --git a/folly/futures/Promise-inl.h b/folly/futures/Promise-inl.h
index 620890ee2da41a14f0847f0ab675c6e292d114cc..c55d34ca66e48e069918c726ebcd2c1ea67d3ed5 100644 (file)
--- a/folly/futures/Promise-inl.h
+++ b/folly/futures/Promise-inl.h
@@ -134,7 +134,7 @@ void Promise<T>::setWith(F&& func) {
 }
 
 template <class T>
-bool Promise<T>::isFulfilled() {
+bool Promise<T>::isFulfilled() const noexcept {
   if (core_) {
     return core_->hasResult();
   }

diff --git a/folly/futures/Promise.h b/folly/futures/Promise.h
index 43cb07db06054b410db131d740998f41ef709599..a2793e2966fa1ff528209f735e27e8a61a9cd73c 100644 (file)
--- a/folly/futures/Promise.h
+++ b/folly/futures/Promise.h
@@ -27,7 +27,7 @@ template <class T> class Future;
 
 template <class T>
 class Promise {
-public:
+ public:
   Promise();
   ~Promise();
 
@@ -93,9 +93,9 @@ public:
   template <class F>
   void setWith(F&& func);
 
-  bool isFulfilled();
+  bool isFulfilled() const noexcept;
 
-private:
+ private:
   typedef typename Future<T>::corePtr corePtr;
   template <class> friend class Future;
 

diff --git a/folly/futures/detail/Core.h b/folly/futures/detail/Core.h
index 0e66d3309d4ff54d146ce11baffaa7588fcb2283..790a45cd3646f427b31e7e86be76537024a3542e 100644 (file)
--- a/folly/futures/detail/Core.h
+++ b/folly/futures/detail/Core.h
@@ -101,7 +101,7 @@ class Core final {
   Core& operator=(Core&&) = delete;
 
   /// May call from any thread
-  bool hasResult() const {
+  bool hasResult() const noexcept {
     switch (fsm_.getState()) {
       case State::OnlyResult:
       case State::Armed:
@@ -115,7 +115,7 @@ class Core final {
   }
 
   /// May call from any thread
-  bool ready() const {
+  bool ready() const noexcept {
     return hasResult();
   }
 

diff --git a/folly/futures/detail/FSM.h b/folly/futures/detail/FSM.h
index 27e035c5b3018875bc7766b42e97009ec4091187..fc3bb117ea872cd5c3a2361a7ed76e6289ee19e8 100644 (file)
--- a/folly/futures/detail/FSM.h
+++ b/folly/futures/detail/FSM.h
@@ -43,7 +43,7 @@ private:
 public:
   explicit FSM(Enum startState) : state_(startState) {}
 
-  Enum getState() const {
+  Enum getState() const noexcept {
     return state_.load(std::memory_order_acquire);
   }