ASoC: sirf-audio-codec: Fix return value check in sirf_audio_codec_driver_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Wed, 30 Jul 2014 00:04:12 +0000 (08:04 +0800)
committerMark Brown <broonie@linaro.org>
Thu, 31 Jul 2014 20:22:17 +0000 (21:22 +0100)
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/codecs/sirf-audio-codec.c

index d90cb0fafcb27d54142f8a2e81df5fd607c4d89e..06ba4923fd5a856ef7ef492d8a285a3031b67d51 100644 (file)
@@ -471,8 +471,8 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)
 
        mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        base = devm_ioremap_resource(&pdev->dev, mem_res);
-       if (base == NULL)
-               return -ENOMEM;
+       if (IS_ERR(base))
+               return PTR_ERR(base);
 
        sirf_audio_codec->regmap = devm_regmap_init_mmio(&pdev->dev, base,
                                            &sirf_audio_codec_regmap_config);