b43: allocate receive buffers big enough for max frame len + offset
authorJohn W. Linville <linville@tuxdriver.com>
Wed, 30 Mar 2011 18:02:46 +0000 (14:02 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 4 Apr 2011 19:22:11 +0000 (15:22 -0400)
Otherwise, skb_put inside of dma_rx can fail...

https://bugzilla.kernel.org/show_bug.cgi?id=32042

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: stable@kernel.org
drivers/net/wireless/b43/dma.c
drivers/net/wireless/b43/dma.h

index 3d5566e7af0ad51ea08088c8adaa03f1c2a1e02b..ff0f5ba14b2cfb60223a19455772fddca719951b 100644 (file)
@@ -1536,7 +1536,7 @@ static void dma_rx(struct b43_dmaring *ring, int *slot)
                dmaaddr = meta->dmaaddr;
                goto drop_recycle_buffer;
        }
-       if (unlikely(len > ring->rx_buffersize)) {
+       if (unlikely(len + ring->frameoffset > ring->rx_buffersize)) {
                /* The data did not fit into one descriptor buffer
                 * and is split over multiple buffers.
                 * This should never happen, as we try to allocate buffers
index a01c2100f166455d055fa1717574fbb85dfdd3f6..e8a80a1251bf602ba89c726d8019188914f73c78 100644 (file)
@@ -163,7 +163,7 @@ struct b43_dmadesc_generic {
 /* DMA engine tuning knobs */
 #define B43_TXRING_SLOTS               256
 #define B43_RXRING_SLOTS               64
-#define B43_DMA0_RX_BUFFERSIZE         IEEE80211_MAX_FRAME_LEN
+#define B43_DMA0_RX_BUFFERSIZE         (B43_DMA0_RX_FRAMEOFFSET + IEEE80211_MAX_FRAME_LEN)
 
 /* Pointer poison */
 #define B43_DMA_PTR_POISON             ((void *)ERR_PTR(-ENOMEM))