gpu: ion: Fix debugfs handling of multiple kernel clients
authorLaura Abbott <lauraa@codeaurora.org>
Mon, 5 Dec 2011 23:32:36 +0000 (15:32 -0800)
committerColin Cross <ccross@android.com>
Fri, 20 Dec 2013 03:25:39 +0000 (19:25 -0800)
Currently, Ion registers all debugfs entries for clients
via pid. If there are multiple kernel clients, this means
the debugfs entry only gets created for the first one. Fix
this by creating debugfs entries by name always. When
creating user clients, specify the name via the pid.

Change-Id: I00cbb284d1c53b3362bb7be9c0275620a9fac167
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
drivers/staging/android/ion/ion.c

index 09a373f4afe9a3d1005c9366a70a2de495e670d6..ada4a02e1ef228d0f2fcafecdec8cc58805adc16 100644 (file)
@@ -718,7 +718,6 @@ struct ion_client *ion_client_create(struct ion_device *dev,
        struct rb_node **p;
        struct rb_node *parent = NULL;
        struct ion_client *entry;
-       char debug_name[64];
        pid_t pid;
 
        get_task_struct(current->group_leader);
@@ -763,15 +762,14 @@ struct ion_client *ion_client_create(struct ion_device *dev,
        rb_link_node(&client->node, parent, p);
        rb_insert_color(&client->node, &dev->clients);
 
-       snprintf(debug_name, 64, "%u", client->pid);
-       client->debug_root = debugfs_create_file(debug_name, 0664,
+       client->debug_root = debugfs_create_file(name, 0664,
                                                dev->clients_debug_root,
                                                client, &debug_client_fops);
        if (!client->debug_root) {
                char buf[256], *path;
                path = dentry_path(dev->clients_debug_root, buf, 256);
                pr_err("Failed to create client debugfs at %s/%s\n",
-                       path, debug_name);
+                       path, name);
        }
 
        up_write(&dev->lock);
@@ -1302,9 +1300,11 @@ static int ion_open(struct inode *inode, struct file *file)
        struct miscdevice *miscdev = file->private_data;
        struct ion_device *dev = container_of(miscdev, struct ion_device, dev);
        struct ion_client *client;
+       char debug_name[64];
 
        pr_debug("%s: %d\n", __func__, __LINE__);
-       client = ion_client_create(dev, "user");
+       snprintf(debug_name, 64, "%u", task_pid_nr(current->group_leader));
+       client = ion_client_create(dev, debug_name);
        if (IS_ERR(client))
                return PTR_ERR(client);
        file->private_data = client;