staging: dgrp: Drop unnecessary typecast
authorGuenter Roeck <linux@roeck-us.net>
Thu, 28 Feb 2013 19:46:57 +0000 (11:46 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 11 Mar 2013 16:51:08 +0000 (09:51 -0700)
An unnecessary typecast in dgrp_net_ops.c causes the following build error
if compiled with W=1.

In function ‘copy_from_user’, inlined from ‘dgrp_net_ioctl’ at
    drivers/staging/dgrp/dgrp_net_ops.c:3408:21:
    arch/x86/include/asm/uaccess_32.h:211:26: error: call to
    ‘copy_from_user_overflow’ declared with attribute error: copy_from_user()
    buffer size is not provably correct

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgrp/dgrp_net_ops.c

index e6018823b9deca9079ff3ee72251a5669ad99b2f..f364e8e1722dab4985a311d1bef34e70947646e8 100644 (file)
@@ -3405,7 +3405,7 @@ static long dgrp_net_ioctl(struct file *file, unsigned int cmd,
                if (size != sizeof(struct link_struct))
                        return -EINVAL;
 
-               if (copy_from_user((void *)(&link), (void __user *) arg, size))
+               if (copy_from_user(&link, (void __user *)arg, size))
                        return -EFAULT;
 
                if (link.lk_fast_rate < 9600)