Fix clang test compilation failures

Summary:
While working on other code I noticed folly stopped compiling
with clang. Fix that.

Test Plan: fbmake runtests (clang and gcc)

Reviewed By: lucian@fb.com

Subscribers: mathieubaudet, njormrod, bmatheny

FB internal diff: D1618189

diff --git a/folly/experimental/symbolizer/test/Crash.cpp b/folly/experimental/symbolizer/test/Crash.cpp
index 3a82b1e71557226f79d0003b0c4c48400b02d7aa..31b0188df5a4fed7cb589d1534bd2db72f66d4a4 100644 (file)
--- a/folly/experimental/symbolizer/test/Crash.cpp
+++ b/folly/experimental/symbolizer/test/Crash.cpp
@@ -18,6 +18,6 @@
 
 int main() {
   folly::symbolizer::installFatalSignalHandler();
-  *(int*) nullptr = 1;
+  __builtin_trap();
   return 0;
 }

diff --git a/folly/gen/test/FileBenchmark.cpp b/folly/gen/test/FileBenchmark.cpp
index 21ae8677d936548355fe40d4fcf6b28167d45cb0..ac10fd1809a9546b0aa282f3dc074d3ee94c96e9 100644 (file)
--- a/folly/gen/test/FileBenchmark.cpp
+++ b/folly/gen/test/FileBenchmark.cpp
@@ -46,7 +46,7 @@ BENCHMARK(ByLine_Pipes, iters) {
     PCHECK(::read(rfd, &buf, 1) == 1);  // wait for startup
   }
 
-  CHECK_ERR(rfd >= 0);
+  CHECK_ERR(rfd);
   auto s = byLine(folly::File(rfd)) | eachTo<int64_t>() | sum;
   folly::doNotOptimizeAway(s);