perf gtk/hists: Display callchain overhead also

Display callchain percent value in the overhead column.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1370337737-30812-4-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c
index 226c7e10f3cc774c130155e215b8f2895e953884..fa9f8a09233ea4e963635902276a2ff706c3ef97 100644 (file)
--- a/tools/perf/ui/gtk/hists.c
+++ b/tools/perf/ui/gtk/hists.c
@@ -134,7 +134,7 @@ static void callchain_list__sym_name(struct callchain_list *cl,
 }
 
 static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store,
-                                   GtkTreeIter *parent, int col)
+                                   GtkTreeIter *parent, int col, u64 total)
 {
        struct rb_node *nd;
        bool has_single_node = (rb_first(root) == rb_last(root));
@@ -144,9 +144,14 @@ static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store,
                struct callchain_list *chain;
                GtkTreeIter iter, new_parent;
                bool need_new_parent;
+               double percent;
+               u64 hits, child_total;
 
                node = rb_entry(nd, struct callchain_node, rb_node);
 
+               hits = callchain_cumul_hits(node);
+               percent = 100.0 * hits / total;
+
                new_parent = *parent;
                need_new_parent = !has_single_node && (node->val_nr > 1);
 
@@ -155,6 +160,9 @@ static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store,
 
                        gtk_tree_store_append(store, &iter, &new_parent);
 
+                       scnprintf(buf, sizeof(buf), "%5.2f%%", percent);
+                       gtk_tree_store_set(store, &iter, 0, buf, -1);
+
                        callchain_list__sym_name(chain, buf, sizeof(buf));
                        gtk_tree_store_set(store, &iter, col, buf, -1);
 
@@ -168,8 +176,14 @@ static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store,
                        }
                }
 
+               if (callchain_param.mode == CHAIN_GRAPH_REL)
+                       child_total = node->children_hit;
+               else
+                       child_total = total;
+
                /* Now 'iter' contains info of the last callchain_list */
-               perf_gtk__add_callchain(&node->rb_root, store, &iter, col);
+               perf_gtk__add_callchain(&node->rb_root, store, &iter, col,
+                                       child_total);
        }
 }
 
@@ -283,8 +297,15 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists,
                }
 
                if (symbol_conf.use_callchain && sort__has_sym) {
+                       u64 total;
+
+                       if (callchain_param.mode == CHAIN_GRAPH_REL)
+                               total = h->stat.period;
+                       else
+                               total = hists->stats.total_period;
+
                        perf_gtk__add_callchain(&h->sorted_chain, store, &iter,
-                                               sym_col);
+                                               sym_col, total);
                }
        }