staging: comedi: addi_apci_1564: remove deadcode in apci1564_cos_cmdtest()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 25 Aug 2014 22:24:02 +0000 (15:24 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Aug 2014 20:20:51 +0000 (13:20 -0700)
Reported by: coverity
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_1564.c

index ce826456a232029311bb49aca023a8207816e2d1..0940c0da96d5b2789eac9beae2730dfc5c24efac 100644 (file)
@@ -285,9 +285,6 @@ static int apci1564_cos_cmdtest(struct comedi_device *dev,
        /* Step 2a : make sure trigger sources are unique */
        /* Step 2b : and mutually compatible */
 
-       if (err)
-               return 2;
-
        /* Step 3: check if arguments are trivially valid */
 
        err |= cfc_check_trigger_arg_is(&cmd->start_arg, 0);
@@ -299,10 +296,9 @@ static int apci1564_cos_cmdtest(struct comedi_device *dev,
        if (err)
                return 3;
 
-       /* step 4: ignored */
+       /* Step 4: fix up any arguments */
 
-       if (err)
-               return 4;
+       /* Step 5: check channel list if it exists */
 
        return 0;
 }