[objdump] Make iterator operator* return a reference.
authorBenjamin Kramer <benny.kra@googlemail.com>
Thu, 24 Sep 2015 14:52:52 +0000 (14:52 +0000)
committerBenjamin Kramer <benny.kra@googlemail.com>
Thu, 24 Sep 2015 14:52:52 +0000 (14:52 +0000)
This is closer to the expected behavior of an iterator and avoids awkward
warnings from clang's -Wrange-loop-analysis below.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@248497 91177308-0d34-0410-b5e6-96231b3b80d8

tools/llvm-objdump/llvm-objdump.cpp

index 9cccd8d838c251b6545595882386106adfc6ad9c..e9f96cbd87253ad463bdaf6af561572f83e845dc 100644 (file)
@@ -189,7 +189,7 @@ public:
       : Predicate(P), Iterator(I), End(E) {
     ScanPredicate();
   }
-  llvm::object::SectionRef operator*() const { return *Iterator; }
+  const llvm::object::SectionRef &operator*() const { return *Iterator; }
   SectionFilterIterator &operator++() {
     ++Iterator;
     ScanPredicate();