ARM: 7297/1: smp_twd: make sure timer is stopped before registering it
authorMarc Zyngier <Marc.Zyngier@arm.com>
Fri, 20 Jan 2012 11:24:47 +0000 (12:24 +0100)
committer黄涛 <huangtao@rock-chips.com>
Wed, 22 Feb 2012 06:09:46 +0000 (14:09 +0800)
On secondary CPUs, the Timer Control Register is not reset
to a sane value before the timer is registered, and the TRM
doesn't seem to indicate any reset value either. In some cases,
the kernel will take an interrupt too early, depending on what
junk was present in the registers at reset time.

The fix is to set the Timer Control Register to 0 before
registering the clock_event_device and enabling the interrupt.

Problem seen on VE (Cortex A5) and Tegra.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/kernel/smp_twd.c

index 5d9e308a0909c4f07edd4b27b398bbf3618c526b..82347d53a8779212d896baffa7b3ccddb61d1d16 100644 (file)
@@ -183,6 +183,8 @@ void __cpuinit twd_timer_setup(struct clock_event_device *clk)
        else
                twd_calibrate_rate();
 
+       __raw_writel(0, twd_base + TWD_TIMER_CONTROL);
+
        clk->name = "local_timer";
        clk->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT |
                        CLOCK_EVT_FEAT_C3STOP;