net: cdc_ncm: fix typo in test for supported formats
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 22 May 2014 07:52:29 +0000 (10:52 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 May 2014 19:53:00 +0000 (15:53 -0400)
There is a typo here where we test for USB_CDC_NCM_NTH32_SIGN instead
of USB_CDC_NCM_NTB32_SUPPORTED.  The test probably still works as
written because 0x686D636E has (1 << 1) set and doesn't have (1 << 0)
set.

Fixes: f8afb73da375 ('net: cdc_ncm: factor out one-time device initialization')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_ncm.c

index ad2a386a6e92ff46560a81216461a332ac9b132d..93c9ca9924ebe3c29078a7ffe269ba490a4f6dbc 100644 (file)
@@ -357,7 +357,8 @@ static int cdc_ncm_init(struct usbnet *dev)
         * "The host shall only send this command while the NCM Data
         *  Interface is in alternate setting 0."
         */
-       if (le16_to_cpu(ctx->ncm_parm.bmNtbFormatsSupported) & USB_CDC_NCM_NTH32_SIGN) {
+       if (le16_to_cpu(ctx->ncm_parm.bmNtbFormatsSupported) &
+                                               USB_CDC_NCM_NTB32_SUPPORTED) {
                dev_dbg(&dev->intf->dev, "Setting NTB format to 16-bit\n");
                err = usbnet_write_cmd(dev, USB_CDC_SET_NTB_FORMAT,
                                       USB_TYPE_CLASS | USB_DIR_OUT