ion: convert map_kernel to return ERR_PTR
authorColin Cross <ccross@android.com>
Wed, 21 Aug 2013 19:50:37 +0000 (12:50 -0700)
committerColin Cross <ccross@android.com>
Fri, 20 Sep 2013 04:03:31 +0000 (23:03 -0500)
ion is going to stop accepting NULL as an error value, use ERR_PTR.

Change-Id: I030e8b72138904e38a4a5d225beaaa98427651fb
Signed-off-by: Colin Cross <ccross@android.com>
drivers/gpu/ion/ion_carveout_heap.c
drivers/gpu/ion/ion_heap.c

index ce8d311968f604a278ad3fc5be5f6902c895ec01..86f35545eaf7253a9c8b95eee5abecf7416f4aa0 100644 (file)
@@ -112,13 +112,18 @@ void ion_carveout_heap_unmap_dma(struct ion_heap *heap,
 void *ion_carveout_heap_map_kernel(struct ion_heap *heap,
                                   struct ion_buffer *buffer)
 {
+       void *ret;
        int mtype = MT_MEMORY_NONCACHED;
 
        if (buffer->flags & ION_FLAG_CACHED)
                mtype = MT_MEMORY;
 
-       return __arm_ioremap(buffer->priv_phys, buffer->size,
+       ret = __arm_ioremap(buffer->priv_phys, buffer->size,
                              mtype);
+       if (ret == NULL)
+               return ERR_PTR(-ENOMEM);
+
+       return ret;
 }
 
 void ion_carveout_heap_unmap_kernel(struct ion_heap *heap,
index bf6a383bd98b05c4ffb89497c9d291896f003ccc..786302de7ed046f2a883ef6c3aa129e551dc333b 100644 (file)
@@ -56,6 +56,9 @@ void *ion_heap_map_kernel(struct ion_heap *heap,
        vaddr = vmap(pages, npages, VM_MAP, pgprot);
        vfree(pages);
 
+       if (vaddr == NULL)
+               return ERR_PTR(-ENOMEM);
+
        return vaddr;
 }