qlogicfas: don't call free_dma()
authorArnd Bergmann <arnd@arndb.de>
Thu, 5 Jun 2014 21:29:48 +0000 (23:29 +0200)
committerChristoph Hellwig <hch@lst.de>
Fri, 25 Jul 2014 21:16:55 +0000 (17:16 -0400)
The qlogicfas scsi driver does not use DMA, and the call to free_dma()
in its exit function seems to have been copied incorrectly from
another driver but never caused trouble.

One case where it gets in the way is randconfig builds on ARM,
which depending on the configuration does not provide a free_dma()
function, causing this build error:

drivers/scsi/qlogicfas.c: In function 'qlogicfas_release':
drivers/scsi/qlogicfas.c:175:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration]
   free_dma(shost->dma_channel);
   ^

Removing the incorrect function calls should be the obvious
fix for this, with no downsides.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/qlogicfas.c

index 13d628b56ff790473d2088759fba4d8a32b7cd1e..a22bb1b40ce2a12d344b741524ee75cee2668d58 100644 (file)
@@ -171,8 +171,6 @@ static int qlogicfas_release(struct Scsi_Host *shost)
                qlogicfas408_disable_ints(priv);        
                free_irq(shost->irq, shost);
        }
-       if (shost->dma_channel != 0xff)
-               free_dma(shost->dma_channel);
        if (shost->io_port && shost->n_io_port)
                release_region(shost->io_port, shost->n_io_port);
        scsi_host_put(shost);