igb: Fix for improper exit in igb_get_i2c_client

This patch fixes an issue where we check for irq's disabled then exit after
explicitly disabling them with spin_lock_irqsave.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Aaron Brown <arron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index b070a97376c8a4e2c4a3573fc737109faf8ed134..d84f28c683c5d85b00d97d3fbea2101663e19da4 100644 (file)
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7750,12 +7750,7 @@ igb_get_i2c_client(struct igb_adapter *adapter, u8 dev_addr)
                }
        }
 
-       /* no client_list found, create a new one as long as
-        * irqs are not disabled
-        */
-       if (unlikely(irqs_disabled()))
-               goto exit;
-
+       /* no client_list found, create a new one */
        client_list = kzalloc(sizeof(*client_list), GFP_KERNEL);
        if (client_list == NULL)
                goto exit;