pinctrl/abx500: destroy mutex if returning early due to error

Current failure path neglects to mutex_destroy() before returning
an error due to an invalid parameter or an error received from
gpiochip_add(). This patch aims to remedy that behaviour.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
index 426b47cd64334d593eddf58e9735a2753fdb3215..81ef5152714b42155861f73e5a4e6b712f02a65b 100644 (file)
--- a/drivers/pinctrl/pinctrl-abx500.c
+++ b/drivers/pinctrl/pinctrl-abx500.c
@@ -1155,11 +1155,13 @@ static int abx500_gpio_probe(struct platform_device *pdev)
        default:
                dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n",
                                (int) platid->driver_data);
+               mutex_destroy(&pct->lock);
                return -EINVAL;
        }
 
        if (!pct->soc) {
                dev_err(&pdev->dev, "Invalid SOC data\n");
+               mutex_destroy(&pct->lock);
                return -EINVAL;
        }
 
@@ -1176,6 +1178,7 @@ static int abx500_gpio_probe(struct platform_device *pdev)
        ret = gpiochip_add(&pct->chip);
        if (ret) {
                dev_err(&pdev->dev, "unable to add gpiochip: %d\n", ret);
+               mutex_destroy(&pct->lock);
                goto out_rem_irq;
        }
        dev_info(&pdev->dev, "added gpiochip\n");