usb: renesas_usbhs: (cosmetic) simplify list operations
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Tue, 14 Feb 2012 10:37:17 +0000 (11:37 +0100)
committerFelipe Balbi <balbi@ti.com>
Tue, 14 Feb 2012 11:44:27 +0000 (13:44 +0200)
list.h already provide helpers to find the first entry and to move list
nodes to the tail of another list. This patch simply uses those helpers,
no functional changes.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/renesas_usbhs/fifo.c

index 03a9cc529c820b3f6ec26c8ef1187c0fa1bbd70d..fb2a88c5c210a2be5e239340cda32ac6bfdff666 100644 (file)
@@ -76,8 +76,7 @@ void usbhs_pkt_push(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt,
                pipe->handler = &usbhsf_null_handler;
        }
 
-       list_del_init(&pkt->node);
-       list_add_tail(&pkt->node, &pipe->list);
+       list_move_tail(&pkt->node, &pipe->list);
 
        /*
         * each pkt must hold own handler.
@@ -107,7 +106,7 @@ static struct usbhs_pkt *__usbhsf_pkt_get(struct usbhs_pipe *pipe)
        if (list_empty(&pipe->list))
                return NULL;
 
-       return list_entry(pipe->list.next, struct usbhs_pkt, node);
+       return list_first_entry(&pipe->list, struct usbhs_pkt, node);
 }
 
 struct usbhs_pkt *usbhs_pkt_pop(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt)