V4L/DVB: em28xx: the default std was not passed on to the subdevs
authorHans Verkuil <hverkuil@xs4all.nl>
Sun, 26 Sep 2010 10:45:15 +0000 (07:45 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Oct 2010 03:06:15 +0000 (01:06 -0200)
The initial em28xx std (PAL) was not passed on to the subdevs. This led to
these tvp5150 kernel log errors when running v4l2-ctl --all:

tvp5150 0-005c: VBI can't be configured without knowing number of lines

The reason was that tvp5150 was still using its own internal default: STD_ALL.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/em28xx/em28xx-video.c

index 741c4fcf0d280832d8d07e4c0abfa9a53ff5e3cf..06cf1979250447a89c8a6b0100cd112671b98056 100644 (file)
@@ -2445,6 +2445,7 @@ int em28xx_register_analog_devices(struct em28xx *dev)
 
        /* set default norm */
        dev->norm = em28xx_video_template.current_norm;
+       v4l2_device_call_all(&dev->v4l2_dev, 0, core, s_std, dev->norm);
        dev->interlaced = EM28XX_INTERLACED_DEFAULT;
        dev->ctl_input = 0;