ALSA: ali5451: remove irq enabling in pointer callback
authorDenis Efremov <yefremov.denis@gmail.com>
Mon, 11 Feb 2013 15:49:48 +0000 (19:49 +0400)
committerTakashi Iwai <tiwai@suse.de>
Mon, 11 Feb 2013 15:52:46 +0000 (16:52 +0100)
snd_ali_pointer function is called with local
interrupts disabled. However it seems very strange to
reenable them in such way.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ali5451/ali5451.c

index 136a393b70abc98dcbe5f0fee9d9c0247b51b375..e760af9d1fb6fa074a278dadd2256214a19df3de 100644 (file)
@@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)
 
        spin_lock(&codec->reg_lock);
        if (!pvoice->running) {
-               spin_unlock_irq(&codec->reg_lock);
+               spin_unlock(&codec->reg_lock);
                return 0;
        }
        outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));