hpsa: do not print ioaccel2 warning messages about unusual completions.
authorRobert Elliott <elliott@hp.com>
Thu, 23 Apr 2015 14:34:00 +0000 (09:34 -0500)
committerJames Bottomley <JBottomley@Odin.com>
Sun, 31 May 2015 18:36:25 +0000 (11:36 -0700)
The SCSI midlayer already prints more detail about completions,
and has logging level options to filter them if not wanted.
These just slow down the system if a lot of errors occur,
stressing error handling even more.

Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Reviewed-by: Kevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Reviewed-by: Hannes Reinecke <hare@Suse.de>
Signed-off-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
drivers/scsi/hpsa.c

index baf7fd0575eed00ebd52248bc026d815cda80913..c15d0b470864da5774128a826f77741240e5b1c4 100644 (file)
@@ -1871,9 +1871,6 @@ static int handle_ioaccel_mode2_error(struct ctlr_info *h,
                case IOACCEL2_STATUS_SR_TASK_COMP_GOOD:
                        break;
                case IOACCEL2_STATUS_SR_TASK_COMP_CHK_COND:
-                       dev_warn(&h->pdev->dev,
-                               "%s: task complete with check condition.\n",
-                               "HP SSD Smart Path");
                        cmd->result |= SAM_STAT_CHECK_CONDITION;
                        if (c2->error_data.data_present !=
                                        IOACCEL2_SENSE_DATA_PRESENT) {
@@ -1893,30 +1890,18 @@ static int handle_ioaccel_mode2_error(struct ctlr_info *h,
                        retry = 1;
                        break;
                case IOACCEL2_STATUS_SR_TASK_COMP_BUSY:
-                       dev_warn(&h->pdev->dev,
-                               "%s: task complete with BUSY status.\n",
-                               "HP SSD Smart Path");
                        retry = 1;
                        break;
                case IOACCEL2_STATUS_SR_TASK_COMP_RES_CON:
-                       dev_warn(&h->pdev->dev,
-                               "%s: task complete with reservation conflict.\n",
-                               "HP SSD Smart Path");
                        retry = 1;
                        break;
                case IOACCEL2_STATUS_SR_TASK_COMP_SET_FULL:
                        retry = 1;
                        break;
                case IOACCEL2_STATUS_SR_TASK_COMP_ABORTED:
-                       dev_warn(&h->pdev->dev,
-                               "%s: task complete with aborted status.\n",
-                               "HP SSD Smart Path");
                        retry = 1;
                        break;
                default:
-                       dev_warn(&h->pdev->dev,
-                               "%s: task complete with unrecognized status: 0x%02x\n",
-                               "HP SSD Smart Path", c2->error_data.status);
                        retry = 1;
                        break;
                }
@@ -1943,9 +1928,6 @@ static int handle_ioaccel_mode2_error(struct ctlr_info *h,
                        break;
                default:
                        retry = 1;
-                       dev_warn(&h->pdev->dev,
-                               "unexpected delivery or target failure, status = 0x%02x\n",
-                               c2->error_data.status);
                }
                break;
        case IOACCEL2_SERV_RESPONSE_TMF_COMPLETE:
@@ -1953,17 +1935,11 @@ static int handle_ioaccel_mode2_error(struct ctlr_info *h,
        case IOACCEL2_SERV_RESPONSE_TMF_SUCCESS:
                break;
        case IOACCEL2_SERV_RESPONSE_TMF_REJECTED:
-               dev_warn(&h->pdev->dev, "task management function rejected.\n");
                retry = 1;
                break;
        case IOACCEL2_SERV_RESPONSE_TMF_WRONG_LUN:
-               dev_warn(&h->pdev->dev, "task management function invalid LUN\n");
                break;
        default:
-               dev_warn(&h->pdev->dev,
-                       "%s: Unrecognized server response: 0x%02x\n",
-                       "HP SSD Smart Path",
-                       c2->error_data.serv_response);
                retry = 1;
                break;
        }