Invert the condition to have a single return.
authorRafael Espindola <rafael.espindola@gmail.com>
Tue, 26 Aug 2014 18:03:35 +0000 (18:03 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Tue, 26 Aug 2014 18:03:35 +0000 (18:03 +0000)
Thanks to David Blaikie for the suggestion.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216468 91177308-0d34-0410-b5e6-96231b3b80d8

tools/llvm-link/llvm-link.cpp

index 6ac10d8dcdaf3b76f60300c88ea788ba8c5e2ee2..17866a06713f532664810a6e111464ca6124c34c 100644 (file)
@@ -63,11 +63,10 @@ loadFile(const char *argv0, const std::string &FN, LLVMContext &Context) {
   SMDiagnostic Err;
   if (Verbose) errs() << "Loading '" << FN << "'\n";
   std::unique_ptr<Module> Result = parseIRFile(FN, Err, Context);
-  if (Result)
-    return Result;
+  if (!Result)
+    Err.print(argv0, errs());
 
-  Err.print(argv0, errs());
-  return nullptr;
+  return Result;
 }
 
 int main(int argc, char **argv) {