Remove redundant linux/version.h includes from net/
authorJesper Juhl <jj@chaosbits.net>
Mon, 20 Jun 2011 12:13:10 +0000 (12:13 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jun 2011 23:03:17 +0000 (16:03 -0700)
It was suggested by "make versioncheck" that the follwing includes of
linux/version.h are redundant:

  /home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed.
  /home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed.
  /home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed.
  /home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed.
  /home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed.

and it seems that it is right.

Beyond manually inspecting the source files I also did a few build
tests with various configs to confirm that including the header in
those files is indeed not needed.

Here's a patch to remove the pointless includes.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/caif/caif_dev.c
net/caif/chnl_net.c
net/ipv4/gre.c
net/netfilter/ipset/ip_set_core.c
net/netfilter/xt_set.c

index 682c0fedf360c3f87177439f3a35e01e18daac18..7c2fa0a0814848c399c64aa9f44fc4fa119fa28b 100644 (file)
@@ -11,7 +11,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
 
-#include <linux/version.h>
 #include <linux/kernel.h>
 #include <linux/if_arp.h>
 #include <linux/net.h>
index c628a57953c98ccf9d6376a4d211785973527f92..865690948bbc7da373cbb12a3abd6c787cb1b7cb 100644 (file)
@@ -7,7 +7,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
 
-#include <linux/version.h>
 #include <linux/fs.h>
 #include <linux/hardirq.h>
 #include <linux/init.h>
index c6933f2ea3105be192c7eaa1ac06045539cd07cc..9dbe10875fbd165a0ea64f6cb17ad97424f90f52 100644 (file)
@@ -16,7 +16,6 @@
 #include <linux/skbuff.h>
 #include <linux/in.h>
 #include <linux/netdevice.h>
-#include <linux/version.h>
 #include <linux/spinlock.h>
 #include <net/protocol.h>
 #include <net/gre.h>
index c012985a5a2640f82ee73658593121d08e621dc7..d7e86ef9d23aa0a11fbd5d80a8f64e4a01c7a8ea 100644 (file)
@@ -17,7 +17,6 @@
 #include <linux/spinlock.h>
 #include <linux/netlink.h>
 #include <linux/rculist.h>
-#include <linux/version.h>
 #include <net/netlink.h>
 
 #include <linux/netfilter.h>
index 19461c462dbd41e3f4a595fbfaf34a7f904cff39..0ec8138aa47052f8966fde995d68f240b7d377d4 100644 (file)
@@ -13,7 +13,6 @@
 
 #include <linux/module.h>
 #include <linux/skbuff.h>
-#include <linux/version.h>
 
 #include <linux/netfilter/x_tables.h>
 #include <linux/netfilter/xt_set.h>