x86/amd-iommu: Move compl-wait command building to own function
authorJoerg Roedel <joerg.roedel@amd.com>
Wed, 6 Apr 2011 08:53:48 +0000 (10:53 +0200)
committerJoerg Roedel <joerg.roedel@amd.com>
Wed, 6 Apr 2011 08:53:48 +0000 (10:53 +0200)
This patch introduces a seperate function for building
completion-wait commands.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
arch/x86/kernel/amd_iommu.c

index 57ca777872206a7ab9df16158f769ee174ed5721..eebd504519c63d9b0a53f775cceb8b0c4e0cc85a 100644 (file)
@@ -383,6 +383,13 @@ irqreturn_t amd_iommu_int_handler(int irq, void *data)
  *
  ****************************************************************************/
 
+static void build_completion_wait(struct iommu_cmd *cmd)
+{
+       memset(cmd, 0, sizeof(*cmd));
+       cmd->data[0] = CMD_COMPL_WAIT_INT_MASK;
+       CMD_SET_TYPE(cmd, CMD_COMPL_WAIT);
+}
+
 /*
  * Writes the command to the IOMMUs command buffer and informs the
  * hardware about the new command. Must be called with iommu->lock held.
@@ -458,9 +465,7 @@ static int __iommu_completion_wait(struct amd_iommu *iommu)
 {
        struct iommu_cmd cmd;
 
-        memset(&cmd, 0, sizeof(cmd));
-        cmd.data[0] = CMD_COMPL_WAIT_INT_MASK;
-        CMD_SET_TYPE(&cmd, CMD_COMPL_WAIT);
+       build_completion_wait(&cmd);
 
         return __iommu_queue_command(iommu, &cmd);
 }