s390/dasd: Fix unresumed device after suspend/resume having no paths
authorStefan Haberland <stefan.haberland@de.ibm.com>
Thu, 2 Apr 2015 11:18:39 +0000 (13:18 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Wed, 15 Apr 2015 10:23:51 +0000 (12:23 +0200)
The DASD device driver prevents I/O from being started on stopped
devices. This also prevented channel paths to be verified and so
the device was unable to be resumed.
Fix by allowing path verification requests on stopped devices.

Signed-off-by: Stefan Haberland <stefan.haberland@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/block/dasd.c

index a5ed35d0cbf3c3372e97cfd61f18a5e398b5de84..57fd66357b959fadaccfa3ecf269dda848bc7166 100644 (file)
@@ -2166,18 +2166,22 @@ static int _dasd_sleep_on(struct dasd_ccw_req *maincqr, int interruptible)
                        cqr->intrc = -ENOLINK;
                        continue;
                }
-               /* Don't try to start requests if device is stopped */
-               if (interruptible) {
-                       rc = wait_event_interruptible(
-                               generic_waitq, !(device->stopped));
-                       if (rc == -ERESTARTSYS) {
-                               cqr->status = DASD_CQR_FAILED;
-                               maincqr->intrc = rc;
-                               continue;
-                       }
-               } else
-                       wait_event(generic_waitq, !(device->stopped));
-
+               /*
+                * Don't try to start requests if device is stopped
+                * except path verification requests
+                */
+               if (!test_bit(DASD_CQR_VERIFY_PATH, &cqr->flags)) {
+                       if (interruptible) {
+                               rc = wait_event_interruptible(
+                                       generic_waitq, !(device->stopped));
+                               if (rc == -ERESTARTSYS) {
+                                       cqr->status = DASD_CQR_FAILED;
+                                       maincqr->intrc = rc;
+                                       continue;
+                               }
+                       } else
+                               wait_event(generic_waitq, !(device->stopped));
+               }
                if (!cqr->callback)
                        cqr->callback = dasd_wakeup_cb;