staging/lustre/llite: A not locked mutex can be unlocked.
authorDmitry Eremin <dmitry.eremin@intel.com>
Mon, 22 Jul 2013 16:06:28 +0000 (00:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Jul 2013 19:39:23 +0000 (12:39 -0700)
In case of memory pressure a not locked mutex can be unlocked
in function ll_file_open(). This is not allowed and subsequent
behavior is not defined.

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3157
Lustre-change: http://review.whamcloud.com/6028
Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John Hammond <johnlockwoodhammond@gmail.com>
Reviewed-by: Nikitas Angelinas <nikitas_angelinas@xyratex.com>
Reviewed-by: Sebastien Buisson <sebastien.buisson@bull.net>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <tao.peng@emc.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/llite/file.c

index 927b3a03e6546addc9c32073925f73e1bcd49643..717682c162eceaa4b839faa7b967015667c18334 100644 (file)
@@ -526,7 +526,7 @@ int ll_file_open(struct inode *inode, struct file *file)
 
        fd = ll_file_data_get();
        if (fd == NULL)
-               GOTO(out_och_free, rc = -ENOMEM);
+               GOTO(out_openerr, rc = -ENOMEM);
 
        fd->fd_file = file;
        if (S_ISDIR(inode->i_mode)) {