Add a TODO about memory operands.
authorEric Christopher <echristo@apple.com>
Fri, 3 Jun 2011 17:21:23 +0000 (17:21 +0000)
committerEric Christopher <echristo@apple.com>
Fri, 3 Jun 2011 17:21:23 +0000 (17:21 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@132559 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

index 6da80dbd6a068e6bb4ac47ac0a44d2ace4b53754..3ff4da4a28aed07b4d7ea97226d03df24222c952 100644 (file)
@@ -5735,7 +5735,11 @@ void SelectionDAGBuilder::visitInlineAsm(ImmutableCallSite CS) {
       // Memory operands really want the address of the value.  If we don't have
       // an indirect input, put it in the constpool if we can, otherwise spill
       // it to a stack slot.
-
+      // TODO: This isn't quite right. We need to handle these according to
+      // the addressing mode that the constraint wants. Also, this may take
+      // an additional register for the computation and we don't want that
+      // either.
+      
       // If the operand is a float, integer, or vector constant, spill to a
       // constant pool entry to get its address.
       const Value *OpVal = OpInfo.CallOperandVal;