[ARM] 5017/1: pxa3xx: Report unsupported wakeup sources in pxa3xx_set_wake()
authorMark Brown <broonie@sirena.org.uk>
Wed, 23 Apr 2008 09:28:18 +0000 (10:28 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Thu, 24 Apr 2008 20:56:35 +0000 (21:56 +0100)
pxa3xx_set_wake() silently accepts unsupported wake sources, causing
users to believe that they have succesfully configured sources that they
haven't.  Fail the operation instead.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: eric miao <eric.y.miao@gmail.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/mach-pxa/pxa3xx.c

index dde355e88fa1574d3760a778a4cb7bf8297d166a..b6a6f5fcc77ad56158bbd01b061c973ca4700285 100644 (file)
@@ -486,6 +486,8 @@ static int pxa3xx_set_wake(unsigned int irq, unsigned int on)
        case IRQ_MMC3:
                mask = ADXER_MFP_GEN12;
                break;
+       default:
+               return -EINVAL;
        }
 
        local_irq_save(flags);