USB: clean up redundant tests on unsigned
authorroel kluin <roel.kluin@gmail.com>
Tue, 21 Oct 2008 04:47:23 +0000 (00:47 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 7 Jan 2009 17:59:49 +0000 (09:59 -0800)
temp, bytes and param->{length,sglen,vary} are unsigned so
these tests do nothing.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ehci-dbg.c
drivers/usb/misc/usbtest.c

index 0cb53ca8d3434c521162e7e1461a01c6c13d7677..7f4ace73d44aee2da8e9484be8f103d8ec1e9bea 100644 (file)
@@ -455,9 +455,7 @@ static void qh_lines (
                                (scratch >> 16) & 0x7fff,
                                scratch,
                                td->urb);
-               if (temp < 0)
-                       temp = 0;
-               else if (size < temp)
+               if (size < temp)
                        temp = size;
                size -= temp;
                next += temp;
@@ -466,9 +464,7 @@ static void qh_lines (
        }
 
        temp = snprintf (next, size, "\n");
-       if (temp < 0)
-               temp = 0;
-       else if (size < temp)
+       if (size < temp)
                temp = size;
        size -= temp;
        next += temp;
index 444c69c447bec115e4757446b6ad8a34ae42816c..5f1a19d1497d108a41a23a7d2d73898bc20cf289 100644 (file)
@@ -192,8 +192,6 @@ static struct urb *simple_alloc_urb (
 {
        struct urb              *urb;
 
-       if (bytes < 0)
-               return NULL;
        urb = usb_alloc_urb (0, GFP_KERNEL);
        if (!urb)
                return urb;