thermal: cpu_cooling: fix return value check in cpufreq_cooling_register()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 25 Oct 2013 13:55:42 +0000 (21:55 +0800)
committerAlex Shi <alex.shi@linaro.org>
Thu, 25 Sep 2014 09:59:26 +0000 (17:59 +0800)
In case of error, the function thermal_cooling_device_register() returns
ERR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
(cherry picked from commit 73b9bcd76d13716cc0e0ab053f8c1ae41f47636e)
Signed-off-by: Alex Shi <alex.shi@linaro.org>
Conflicts:
drivers/thermal/cpu_cooling.c

drivers/thermal/cpu_cooling.c

index dc50315174d81e340a4e55840113c2bfdb1133a6..8c1547424502c8af163cab4db689f2aa53930477 100644 (file)
@@ -482,7 +482,7 @@ __cpufreq_cooling_register(struct device_node *np,
        if (IS_ERR(cool_dev)) {
                release_idr(&cpufreq_idr, cpufreq_dev->id);
                kfree(cpufreq_dev);
-               return ERR_PTR(-EINVAL);
+               return cool_dev;
        }
        cpufreq_dev->cool_dev = cool_dev;
        cpufreq_dev->cpufreq_state = 0;