xfs: remove the first extent special case in xfs_bmap_add_extent
authorChristoph Hellwig <hch@infradead.org>
Sun, 18 Sep 2011 20:40:41 +0000 (20:40 +0000)
committerAlex Elder <aelder@sgi.com>
Wed, 12 Oct 2011 02:15:03 +0000 (21:15 -0500)
Both xfs_bmap_add_extent_hole_delay and xfs_bmap_add_extent_hole_real
already contain code to handle the case where there is no extent to
merge with, which is effectively the same as the code duplicated here.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/xfs_bmap.c

index a6075c0f8456c1196a1c32b8b968ca2e04da0337..927e5454a43c1b469ce98162e79ee3396ce25c40 100644 (file)
@@ -465,27 +465,10 @@ xfs_bmap_add_extent(
        ASSERT(*idx >= 0);
        ASSERT(*idx <= nextents);
 
-       /*
-        * This is the first extent added to a new/empty file.
-        * Special case this one, so other routines get to assume there are
-        * already extents in the list.
-        */
-       if (nextents == 0) {
-               xfs_iext_insert(ip, *idx, 1, new,
-                               whichfork == XFS_ATTR_FORK ? BMAP_ATTRFORK : 0);
-
-               ASSERT(cur == NULL);
-
-               if (!isnullstartblock(new->br_startblock)) {
-                       XFS_IFORK_NEXT_SET(ip, whichfork, 1);
-                       logflags = XFS_ILOG_CORE | xfs_ilog_fext(whichfork);
-               } else
-                       logflags = 0;
-       }
        /*
         * Any kind of new delayed allocation goes here.
         */
-       else if (isnullstartblock(new->br_startblock)) {
+       if (isnullstartblock(new->br_startblock)) {
                if (cur)
                        ASSERT((cur->bc_private.b.flags &
                                XFS_BTCUR_BPRV_WASDEL) == 0);