[PATCH] LSM: add missing hook to do_compat_readv_writev()
authorJames Morris <jmorris@namei.org>
Wed, 26 Apr 2006 06:45:03 +0000 (02:45 -0400)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 26 Apr 2006 14:52:21 +0000 (07:52 -0700)
This patch addresses a flaw in LSM, where there is no mediation of readv()
and writev() in for 32-bit compatible apps using a 64-bit kernel.

This bug was discovered and fixed initially in the native readv/writev
code [1], but was not fixed in the compat code.  Thanks to Al for spotting
this one.

  [1] http://lwn.net/Articles/154282/

Signed-off-by: James Morris <jmorris@namei.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/compat.c

index 7f8e26ea427c4bed0d125c4fa051e28a7db6123f..2e32bd3404748d94aed3fef0e053d822c69d0ef1 100644 (file)
@@ -1217,6 +1217,10 @@ static ssize_t compat_do_readv_writev(int type, struct file *file,
        if (ret < 0)
                goto out;
 
+       ret = security_file_permission(file, type == READ ? MAY_READ:MAY_WRITE);
+       if (ret)
+               goto out;
+
        fnv = NULL;
        if (type == READ) {
                fn = file->f_op->read;