fixing infinite OPEN loop in 4.0 stateid recovery
authorOlga Kornievskaia <kolga@netapp.com>
Fri, 15 May 2015 15:45:31 +0000 (11:45 -0400)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Mon, 1 Jun 2015 13:58:02 +0000 (09:58 -0400)
Problem: When an operation like WRITE receives a BAD_STATEID, even though
recovery code clears the RECLAIM_NOGRACE recovery flag before recovering
the open state, because of clearing delegation state for the associated
inode, nfs_inode_find_state_and_recover() gets called and it makes the
same state with RECLAIM_NOGRACE flag again. As a results, when we restart
looking over the open states, we end up in the infinite loop instead of
breaking out in the next test of state flags.

Solution: unset the RECLAIM_NOGRACE set because of
calling of nfs_inode_find_state_and_recover() after returning from calling
recover_open() function.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
fs/nfs/nfs4state.c

index 2782cfca22650922e012a4f86a1755e3cca68243..ddef1dc80cf7d7c88b9202bf01746c3497bacf28 100644 (file)
@@ -1482,6 +1482,8 @@ restart:
                                        spin_unlock(&state->state_lock);
                                }
                                nfs4_put_open_state(state);
+                               clear_bit(NFS4CLNT_RECLAIM_NOGRACE,
+                                       &state->flags);
                                spin_lock(&sp->so_lock);
                                goto restart;
                        }