drm/i915: BUG on impossible pch dp port
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 26 Oct 2012 08:58:16 +0000 (10:58 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 11 Nov 2012 22:50:58 +0000 (23:50 +0100)
Since it is one. We need to move this code to encoder specific callbacks
eventually, to kill all that inversion of control ...

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c

index 8216cfb57be45764be04da999c1fea1d63ad06dc..d6cdbc622dd02dba89b9e8ae624b6b5bd7e477e3 100644 (file)
@@ -3096,9 +3096,7 @@ static void ironlake_pch_enable(struct drm_crtc *crtc)
                        temp |= TRANS_DP_PORT_SEL_D;
                        break;
                default:
-                       DRM_DEBUG_KMS("Wrong PCH DP port return. Guess port B\n");
-                       temp |= TRANS_DP_PORT_SEL_B;
-                       break;
+                       BUG();
                }
 
                I915_WRITE(reg, temp);