netpoll: Warn if more packets are processed than are budgeted
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 15 Mar 2014 03:47:15 +0000 (20:47 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Mar 2014 19:47:22 +0000 (15:47 -0400)
There is already a warning for this case in the normal netpoll path,
but put a copy here in case how netpoll calls the poll functions
causes a differenet result.

netpoll will shortly call the napi poll routine with a budget 0 to
avoid any rx packets being processed.  As nothing does that today
we may encounter drivers that have problems so a netpoll specific
warning seems desirable.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/netpoll.c

index d9e3d74ec9ac335cad79b923d87b8d2ea5edbcf6..2ad330e02967132369df3794a5c79e5142f7ebd6 100644 (file)
@@ -158,6 +158,7 @@ static int poll_one_napi(struct napi_struct *napi, int budget)
        set_bit(NAPI_STATE_NPSVC, &napi->state);
 
        work = napi->poll(napi, budget);
+       WARN_ONCE(work > budget, "%pF exceeded budget in poll\n", napi->poll);
        trace_napi_poll(napi);
 
        clear_bit(NAPI_STATE_NPSVC, &napi->state);