timekeeping: fix 32-bit overflow in get_monotonic_boottime
authorColin Cross <ccross@android.com>
Wed, 26 Sep 2012 21:21:22 +0000 (14:21 -0700)
committerColin Cross <ccross@android.com>
Wed, 26 Sep 2012 22:04:01 +0000 (15:04 -0700)
get_monotonic_boottime adds three nanonsecond values stored
in longs, followed by an s64.  If the long values are all
close to 1e9 the first three additions can overflow and
become negative when added to the s64.  Cast the first
value to s64 so that all additions are 64 bit.

Change-Id: Ic996d8b6fbef0b72f2d027b0d8ef5259b5c1a540
Signed-off-by: Colin Cross <ccross@android.com>
kernel/time/timekeeping.c

index 9b28d0407715088b86dea6926290dda269ba24b4..06a5f310fb8e84ccff933b788896144bdce23c15 100644 (file)
@@ -1002,7 +1002,7 @@ void get_monotonic_boottime(struct timespec *ts)
        } while (read_seqretry(&xtime_lock, seq));
 
        set_normalized_timespec(ts, ts->tv_sec + tomono.tv_sec + sleep.tv_sec,
-                       ts->tv_nsec + tomono.tv_nsec + sleep.tv_nsec + nsecs);
+               (s64)ts->tv_nsec + tomono.tv_nsec + sleep.tv_nsec + nsecs);
 }
 EXPORT_SYMBOL_GPL(get_monotonic_boottime);