staging: vt6656: Remove static declaration vnt_start_interrupt_urb_complete
authorMalcolm Priestley <tvboxspy@gmail.com>
Mon, 21 Jul 2014 21:40:42 +0000 (22:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Jul 2014 21:54:31 +0000 (14:54 -0700)
Moving vnt_start_interrupt_urb in visibility of vnt_start_interrupt_urb_complete

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/usbpipe.c

index 9a8874917f8d5307cf85ffa71974b05fa1ec6cb8..8bd776ec84dfded83c3f31ee2a8758ecdb99bf6f 100644 (file)
@@ -57,7 +57,6 @@
 #define URB_ASYNC_UNLINK    0
 #endif
 
-static void vnt_start_interrupt_urb_complete(struct urb *urb);
 static void vnt_submit_rx_urb_complete(struct urb *urb);
 static void vnt_tx_context_complete(struct urb *urb);
 
@@ -117,33 +116,6 @@ void vnt_control_in_u8(struct vnt_private *priv, u8 reg, u8 reg_off, u8 *data)
                        reg_off, reg, sizeof(u8), data);
 }
 
-int vnt_start_interrupt_urb(struct vnt_private *priv)
-{
-       int status = STATUS_FAILURE;
-
-       if (priv->int_buf.in_use == true)
-               return STATUS_FAILURE;
-
-       priv->int_buf.in_use = true;
-
-       usb_fill_int_urb(priv->interrupt_urb,
-               priv->usb,
-               usb_rcvintpipe(priv->usb, 1),
-               priv->int_buf.data_buf,
-               MAX_INTERRUPT_SIZE,
-               vnt_start_interrupt_urb_complete,
-               priv,
-               priv->int_interval);
-
-       status = usb_submit_urb(priv->interrupt_urb, GFP_ATOMIC);
-       if (status) {
-               dev_dbg(&priv->usb->dev, "Submit int URB failed %d\n", status);
-               priv->int_buf.in_use = false;
-       }
-
-       return status;
-}
-
 static void vnt_start_interrupt_urb_complete(struct urb *urb)
 {
        struct vnt_private *priv = urb->context;
@@ -182,6 +154,33 @@ static void vnt_start_interrupt_urb_complete(struct urb *urb)
        return;
 }
 
+int vnt_start_interrupt_urb(struct vnt_private *priv)
+{
+       int status = STATUS_FAILURE;
+
+       if (priv->int_buf.in_use == true)
+               return STATUS_FAILURE;
+
+       priv->int_buf.in_use = true;
+
+       usb_fill_int_urb(priv->interrupt_urb,
+                        priv->usb,
+                        usb_rcvintpipe(priv->usb, 1),
+                        priv->int_buf.data_buf,
+                        MAX_INTERRUPT_SIZE,
+                        vnt_start_interrupt_urb_complete,
+                        priv,
+                        priv->int_interval);
+
+       status = usb_submit_urb(priv->interrupt_urb, GFP_ATOMIC);
+       if (status) {
+               dev_dbg(&priv->usb->dev, "Submit int URB failed %d\n", status);
+               priv->int_buf.in_use = false;
+       }
+
+       return status;
+}
+
 int vnt_submit_rx_urb(struct vnt_private *priv, struct vnt_rcb *rcb)
 {
        int status = 0;