mfd: twl6040: Cleanup in early error handling in probe function
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Fri, 12 Jul 2013 11:32:04 +0000 (13:32 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Wed, 31 Jul 2013 00:02:57 +0000 (02:02 +0200)
The err: label is not needed we can just return instead of the jump there.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/twl6040.c

index 3bd110e7f51890b1c5941e9449ec00dec532c0e9..4d8d3b74d4e3dd3c404787d3a9559c74549e4306 100644 (file)
@@ -533,16 +533,12 @@ static int twl6040_probe(struct i2c_client *client,
 
        twl6040 = devm_kzalloc(&client->dev, sizeof(struct twl6040),
                               GFP_KERNEL);
-       if (!twl6040) {
-               ret = -ENOMEM;
-               goto err;
-       }
+       if (!twl6040)
+               return -ENOMEM;
 
        twl6040->regmap = devm_regmap_init_i2c(client, &twl6040_regmap_config);
-       if (IS_ERR(twl6040->regmap)) {
-               ret = PTR_ERR(twl6040->regmap);
-               goto err;
-       }
+       if (IS_ERR(twl6040->regmap))
+               return PTR_ERR(twl6040->regmap);
 
        i2c_set_clientdata(client, twl6040);
 
@@ -660,7 +656,7 @@ gpio_err:
        regulator_bulk_disable(TWL6040_NUM_SUPPLIES, twl6040->supplies);
 regulator_get_err:
        i2c_set_clientdata(client, NULL);
-err:
+
        return ret;
 }